Skip to content

gh-138122: Refactor the CLI of profiling.sampling into subcommands #141813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 8 commits into from
Nov 24, 2025
Merged

gh-138122: Refactor the CLI of profiling.sampling into subcommands #141813

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
db2ed3b
gh-138122: Refactor the CLI of profile.sampling into subcommands
pablogsal Nov 21, 2025
d6ca1b3
fixup! gh-138122: Refactor the CLI of profile.sampling into subcommands
pablogsal Nov 21, 2025
54be163
fixup! fixup! gh-138122: Refactor the CLI of profile.sampling into su…
pablogsal Nov 21, 2025
7d90c37
Merge remote-tracking branch 'upstream/main' into gh-138122-2
pablogsal Nov 21, 2025
817fdc0
fixup! Merge remote-tracking branch 'upstream/main' into gh-138122-2
pablogsal Nov 21, 2025
170760b
Address feedback
pablogsal Nov 22, 2025
6e4c0d9
Address Laszlo's review
pablogsal Nov 23, 2025
271df56
Update Lib/profiling/sampling/cli.py
pablogsal Nov 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! gh-138122: Refactor the CLI of profile.sampling into subcommands
  • Loading branch information
@pablogsal
pablogsal committed Nov 21, 2025
commit d6ca1b3f2756490c2627f45fe6e0dc1cbec32d4e
2 changes: 2 additions & 0 deletions Lib/profiling/sampling/sample.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
from .gecko_collector import GeckoCollector
from .constants import (
PROFILING_MODE_WALL,
PROFILING_MODE_CPU,
PROFILING_MODE_GIL,
PROFILING_MODE_ALL,
)
try:
Expand Down
9 changes: 5 additions & 4 deletions Lib/test/test_profiling/test_sampling_profiler/test_modes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,10 +444,11 @@ def test_mode_constants_are_defined(self):

def test_parse_mode_function(self):
"""Test the _parse_mode function with all valid modes."""
self.assertEqual(profiling.sampling.sample._parse_mode("wall"), 0)
self.assertEqual(profiling.sampling.sample._parse_mode("cpu"), 1)
self.assertEqual(profiling.sampling.sample._parse_mode("gil"), 2)
from profiling.sampling.cli import _parse_mode
self.assertEqual(_parse_mode("wall"), 0)
self.assertEqual(_parse_mode("cpu"), 1)
self.assertEqual(_parse_mode("gil"), 2)

# Test invalid mode raises KeyError
with self.assertRaises(KeyError):
profiling.sampling.sample._parse_mode("invalid")
_parse_mode("invalid")
2 changes: 1 addition & 1 deletion Misc/NEWS.d/3.15.0a2.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,7 @@ Add :func:`os.reload_environ` to ``os.__all__``.
.. nonce: L13UCV
.. section: Library

Fix :func:`profiling.sampling.sample` incorrectly handling a
Fix ``profiling.sampling.sample()`` incorrectly handling a
:exc:`FileNotFoundError` or :exc:`PermissionError`.

..
Expand Down
2 changes: 1 addition & 1 deletion Misc/NEWS.d/next/Library/2025-11-17-00-53-51.gh-issue-141645.TC3TL3.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Add a new ``--live`` mode to the tachyon profiler in
:mod:`profiling.sampling` module. This mode consist of a live TUI that
:mod:`!profiling.sampling` module. This mode consist of a live TUI that
displays real-time profiling statistics as the target application runs,
similar to ``top``. Patch by Pablo Galindo
Loading