Skip to content

gh-138122: Allow to filter by thread in tachyon's flamegraph #139216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 4 commits into from
Sep 25, 2025
Merged

gh-138122: Allow to filter by thread in tachyon's flamegraph #139216

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b1e1a0e
gh-138122: Allow to filter by thread in tachyon's flamegraph
pablogsal Sep 21, 2025
3ec314d
Simplify
pablogsal Sep 21, 2025
1a86c1b
Fix tests
pablogsal Sep 21, 2025
1e96289
Address code review
pablogsal Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Address code review
  • Loading branch information
@pablogsal
pablogsal committed Sep 25, 2025
commit 1e9628941d874b22d09ed536b161b4c89d46edd2
2 changes: 1 addition & 1 deletion Lib/profiling/sampling/flamegraph.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ body {
}

.thread-filter-wrapper {
display: inline-flex;
display: none;
align-items: center;
margin-left: 16px;
background: white;
Expand Down
10 changes: 3 additions & 7 deletions Lib/profiling/sampling/flamegraph.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,10 +536,6 @@ function initThreadFilter(data) {
const threadWrapper = document.querySelector('.thread-filter-wrapper');

if (!threadFilter || !data.threads) {
// Hide thread filter if no thread data
if (threadWrapper) {
threadWrapper.style.display = 'none';
}
return;
}

Expand All @@ -555,9 +551,9 @@ function initThreadFilter(data) {
threadFilter.appendChild(option);
});

// Hide filter if only one thread or no threads
if (threads.length <= 1 && threadWrapper) {
threadWrapper.style.display = 'none';
// Show filter if more than one thread
if (threads.length > 1 && threadWrapper) {
threadWrapper.style.display = 'inline-flex';
}
}

Expand Down
2 changes: 1 addition & 1 deletion Lib/profiling/sampling/sample.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -754,7 +754,7 @@ def main():
"--mode",
choices=["wall", "cpu", "gil"],
default="wall",
help="Sampling mode: wall (all threads), cpu (only CPU-running threads), gil (only GIL-holding threads)",
help="Sampling mode: wall (all threads), cpu (only CPU-running threads), gil (only GIL-holding threads) (default: wall)",
)

# Output format selection
Expand Down
Loading