gh-79986: Add parsing for References/In-Reply-To email headers #137201
Conversation
|
Ping, a review would be appreciated. |
|
Ping again. |
bitdancer
left a comment
bitdancer
left a comment
There was a problem hiding this comment.
Thanks for working on this! I have a few style comments and one logic change request.
| @@ -0,0 +1,2 @@ | |||
| Add parsing for References/In-Reply-To email headers, preventing them from | |||
| being folded. | |||
There was a problem hiding this comment.
I would say "Add parsing for References and In-Reply-To headers to the :mod:email library that parses the header content as lists of message id tokens. This prevents them from being folded incorrectly."
(I'd love to add support for MessageID objects (like Address objects) an an 'ids' attribute to the headers, but that's a much bigger task and not the focus of this PR.)
There was a problem hiding this comment.
I agree, and I actually considered doing that, but decided to fix the invalid behaviour first.
There was a problem hiding this comment.
Good choice: that will be a new feature while this will be a bug fix and backported unless someone objects.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
elenril
force-pushed
the
email_references
branch
2 times, most recently
from
a1fb731 to
c474293
Compare
This is a followup to 46d88a1 (python#13397), which added parsing for Message-ID. Similar handling is needed for the other two identification headers.
elenril
force-pushed
the
email_references
branch
from
c474293 to
8abd6fc
Compare
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @bitdancer: please review the changes made to this pull request. |
bitdancer
added
needs backport to 3.13
|
Thanks @elenril for the PR, and @bitdancer for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
|
Thanks @elenril for the PR, and @bitdancer for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
…ythonGH-137201) This is a followup to 46d88a1 (pythonGH-13397), which added parsing for Message-ID. Similar handling is needed for the other two identification headers. (cherry picked from commit 79aa43a) Co-authored-by: elenril <[email protected]>
…ythonGH-137201) This is a followup to 46d88a1 (pythonGH-13397), which added parsing for Message-ID. Similar handling is needed for the other two identification headers. (cherry picked from commit 79aa43a) Co-authored-by: elenril <[email protected]>
|
GH-142573 is a backport of this pull request to the 3.14 branch. |
|
GH-142574 is a backport of this pull request to the 3.13 branch. |
…ython#137201) This is a followup to 46d88a1 (python#13397), which added parsing for Message-ID. Similar handling is needed for the other two identification headers.
2 participants
This is a followup to 46d88a1 (#13397),
which added parsing for Message-ID. Similar handling is needed for the
other two identification headers.