Skip to content

gh-137007: Track executor before any possible deallocations #137016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fidget-Spinner merged 8 commits into from
Dec 10, 2025
Merged

gh-137007: Track executor before any possible deallocations #137016

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
31ad0d9
Track executor before any possible deallocations
Fidget-Spinner Jul 22, 2025
c16da4f
📜🤖 Added by blurb_it.
blurb-it[bot] Jul 22, 2025
4f9f6de
move further up
Fidget-Spinner Jul 22, 2025
d9225ee
Merge branch 'track-before-deallocating' of github.com:Fidget-Spinner…
Fidget-Spinner Jul 22, 2025
a4f3d54
Merge remote-tracking branch 'upstream/main' into track-before-deallo…
Fidget-Spinner Nov 7, 2025
4ae3405
track before immortalizing
Fidget-Spinner Nov 7, 2025
bc2da12
remove useless track
Fidget-Spinner Dec 9, 2025
5a4c18a
Merge branch 'main' into track-before-deallocating
Fidget-Spinner Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Track executor before any possible deallocations
  • Loading branch information
@Fidget-Spinner
Fidget-Spinner committed Jul 22, 2025
commit 31ad0d90125ad8422aaf8e346b4371437042c0bb
5 changes: 4 additions & 1 deletion Python/optimizer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1222,6 +1222,10 @@ make_executor_from_uops(_PyUOpInstruction *buffer, int length, const _PyBloomFil
}
sanity_check(executor);
#endif
// Note: this MUST be here before any Py_DECREF(executor).
// Otherwise, the GC tries to untrack a still untracked object
// during dealloc.
_PyObject_GC_TRACK(executor);
#ifdef _Py_JIT
executor->jit_code = NULL;
executor->jit_side_entry = NULL;
Expand All @@ -1234,7 +1238,6 @@ make_executor_from_uops(_PyUOpInstruction *buffer, int length, const _PyBloomFil
return NULL;
Copy link
Member Author

@Fidget-Spinner Fidget-Spinner Jul 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to reviewers: the bad dealloc happens right above this line at line 1233/1238 depending on which diff you view.

}
#endif
_PyObject_GC_TRACK(executor);
return executor;
}

Expand Down
Loading