gh-134584: Eliminate redundant refcounting from _CALL_STR_1
#136070
Merged
+58
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manjusaka <[email protected]>
Zheaoli
requested review from
Fidget-Spinner,
markshannon and
tomasr8
as code owners
31 tasks
Signed-off-by: Manjusaka <[email protected]>
Member
|
Thanks! This looks great to me. Just waiting for Mark's PR on TOS caching to get merged. |
Signed-off-by: Manjusaka <[email protected]>
Signed-off-by: Manjusaka <[email protected]>
…ka/refcount-call-str
Signed-off-by: Manjusaka <[email protected]>
Contributor
Author
|
@Fidget-Spinner Thanks for your time, I have update the PR like what we do in #142604 BTW just for personal interest, May I ask why we revert the code generator change in #142604 ? |
Fidget-Spinner
approved these changes
Dec 14, 2025
Member
Fidget-Spinner
left a comment
Fidget-Spinner
left a comment
There was a problem hiding this comment.
Thank you. This is great!
Member
I realised we can get the same thing with |
Contributor
Author
Got it! Thanks your time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.