Skip to content

gh-134584: Eliminate redundant refcounting from _STORE_SUBSCR_LIST_INT #135907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
corona10 wants to merge 3 commits into from
Closed

gh-134584: Eliminate redundant refcounting from _STORE_SUBSCR_LIST_INT #135907

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a0ba51f
gh-134584: Eliminate redundant refcounting from STORE_SUBSCR_LIST_INT
corona10 Jun 25, 2025
a5b05c0
add test case for expected failure
corona10 Jun 25, 2025
f26ad6c
Merge remote-tracking branch 'upstream/main' into gh-134584-_STORE_SU…
corona10 Dec 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add test case for expected failure
  • Loading branch information
@corona10
corona10 committed Jun 25, 2025
commit a5b05c072ca49c74e0d8fef3c27e30718b21b302
15 changes: 9 additions & 6 deletions Lib/test/test_capi/test_opt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2365,17 +2365,20 @@ def testfunc(n):
def test_store_subscr_int(self):
def testfunc(args):
n = args[0]
l = [0] * n
ret = 0
for idx in range(n):
l[idx] = idx
l = [0, 0, 0, 0]
for _ in range(n):
l[0] = 1
l[1] = 2
l[2] = 3
l[3] = 4
return sum(l)

res, ex = self._run_with_optimizer(testfunc, (TIER2_THRESHOLD,))
self.assertEqual(res, sum(range(TIER2_THRESHOLD)))
self.assertEqual(res, 10)
self.assertIsNotNone(ex)
uops = get_opnames(ex)
self.assertIn("_POP_TOP_INT", uops)
self.assertIn("_POP_TOP_NOP", uops)
self.assertNotIn("_POP_TOP_INT", uops)

def test_attr_promotion_failure(self):
# We're not testing for any specific uops here, just
Expand Down
Loading