Skip to content

gh-134584: Eliminate redundant refcounting from _CALL_TUPLE_1 #135860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fidget-Spinner merged 6 commits into from
Dec 11, 2025
Merged

gh-134584: Eliminate redundant refcounting from _CALL_TUPLE_1 #135860

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
af1172a
eliminate refcount from `_CALL_TUPLE_1`
noamcohen97 Jun 23, 2025
5a805a9
test case
noamcohen97 Jun 23, 2025
c7c4873
news entry
noamcohen97 Jun 23, 2025
6c4d7f3
Merge branch 'main' into refcount-call-tuple-1
noamcohen97 Dec 11, 2025
f392667
move `INPUTS_DEAD()` to the right place
noamcohen97 Dec 11, 2025
2aaafd2
add `pop_3_error`
noamcohen97 Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test case
  • Loading branch information
@noamcohen97
noamcohen97 committed Jun 23, 2025
commit 5a805a94635bc5046faf196dad8ca52ef8f8ac11
15 changes: 15 additions & 0 deletions Lib/test/test_capi/test_opt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1841,6 +1841,21 @@ def testfunc(n):
uops = get_opnames(ex)
self.assertNotIn("_GUARD_IS_NOT_NONE_POP", uops)

def test_call_tuple_1_pop_top(self):
def testfunc(n):
x = 0
for _ in range(n):
t = tuple(())
x += len(t) == 0
return x

res, ex = self._run_with_optimizer(testfunc, TIER2_THRESHOLD)
self.assertEqual(res, TIER2_THRESHOLD)
self.assertIsNotNone(ex)
uops = get_opnames(ex)
self.assertIn("_CALL_TUPLE_1", uops)
self.assertIn("_POP_TOP_NOP", uops)

def test_call_str_1(self):
def testfunc(n):
x = 0
Expand Down