Skip to content

gh-134584: Eliminate redundant refcounting from _CALL_TYPE_1 #135818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fidget-Spinner merged 13 commits into from
Dec 23, 2025
Merged

gh-134584: Eliminate redundant refcounting from _CALL_TYPE_1 #135818

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
85ab405
Eliminate redundant refcounting from _CALL_TYPE_1
tomasr8 Jun 23, 2025
f927209
Add a new uop
tomasr8 Jun 23, 2025
bbf1c9d
Add news entry
tomasr8 Jun 23, 2025
81f9b44
Do not close callable stackref
tomasr8 Jun 23, 2025
6934f63
Update remove_unneeded_uops with new uops
tomasr8 Jun 23, 2025
e86897a
Do not close arg
tomasr8 Dec 22, 2025
bd62d15
Merge remote-tracking branch 'upstream/main' into jit-refcount-call-type
tomasr8 Dec 22, 2025
ca15e78
Update test
tomasr8 Dec 22, 2025
bcb805d
Rename _SWAP_.. to _SHUFFLE_2_..
tomasr8 Dec 22, 2025
56fa30f
Merge remote-tracking branch 'upstream/main' into jit-refcount-call-type
tomasr8 Dec 23, 2025
225d6db
Regenerate files
tomasr8 Dec 23, 2025
bba9435
address review
Fidget-Spinner Dec 23, 2025
6ffffa6
Merge remote-tracking branch 'upstream/main' into pr/135818
Fidget-Spinner Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update remove_unneeded_uops with new uops
  • Loading branch information
@tomasr8
tomasr8 committed Jun 23, 2025
commit 6934f633a41378d010b4236f64a2535c9ebeafb9
3 changes: 2 additions & 1 deletion Lib/test/test_capi/test_opt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1819,9 +1819,10 @@ def testfunc(n):
self.assertIsNotNone(ex)
uops = get_opnames(ex)
# When the result of type(...) is known, _CALL_TYPE_1 is replaced with
# _POP_CALL_ONE_LOAD_CONST_INLINE_BORROW which is optimized away in
# _SWAP_CALL_ONE_LOAD_CONST_INLINE_BORROW which is optimized away in
# remove_unneeded_uops.
self.assertNotIn("_CALL_TYPE_1", uops)
self.assertNotIn("_SWAP_CALL_ONE_LOAD_CONST_INLINE_BORROW", uops)
self.assertNotIn("_POP_CALL_ONE_LOAD_CONST_INLINE_BORROW", uops)
self.assertNotIn("_POP_CALL_LOAD_CONST_INLINE_BORROW", uops)
self.assertNotIn("_POP_TOP_LOAD_CONST_INLINE_BORROW", uops)
Expand Down
6 changes: 6 additions & 0 deletions Python/optimizer_analysis.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -566,7 +566,9 @@ const uint16_t op_without_push[MAX_UOP_ID + 1] = {
[_POP_TOP_LOAD_CONST_INLINE] = _POP_TOP,
[_POP_TOP_LOAD_CONST_INLINE_BORROW] = _POP_TOP,
[_POP_TWO_LOAD_CONST_INLINE_BORROW] = _POP_TWO,
[_POP_CALL_ONE_LOAD_CONST_INLINE_BORROW] = _POP_CALL_ONE,
[_POP_CALL_TWO_LOAD_CONST_INLINE_BORROW] = _POP_CALL_TWO,
[_SWAP_CALL_ONE_LOAD_CONST_INLINE_BORROW] = _POP_CALL_ONE_LOAD_CONST_INLINE_BORROW,
};

const bool op_skip[MAX_UOP_ID + 1] = {
Expand All @@ -578,6 +580,10 @@ const bool op_skip[MAX_UOP_ID + 1] = {

const uint16_t op_without_pop[MAX_UOP_ID + 1] = {
[_POP_TOP] = _NOP,
[_POP_TOP_NOP] = _NOP,
[_POP_TOP_INT] = _NOP,
[_POP_TOP_FLOAT] = _NOP,
[_POP_TOP_UNICODE] = _NOP,
[_POP_TOP_LOAD_CONST_INLINE] = _LOAD_CONST_INLINE,
[_POP_TOP_LOAD_CONST_INLINE_BORROW] = _LOAD_CONST_INLINE_BORROW,
[_POP_TWO] = _POP_TOP,
Expand Down
Loading