Skip to content

gh-134584: Eliminate redundant refcounting from _BINARY_OP_ADD_UNICODE #135817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
corona10 wants to merge 5 commits into from
Closed

gh-134584: Eliminate redundant refcounting from _BINARY_OP_ADD_UNICODE #135817

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d5afe15
gh-134584: Elimiate redundant refcounting from _BINARY_OP_X_UNICODE
corona10 Jun 22, 2025
46b423f
WIP
corona10 Jun 22, 2025
c901079
Address code review
corona10 Jun 22, 2025
ea112a5
Address code review
corona10 Jun 22, 2025
d95aee9
Merge remote-tracking branch 'upstream/main' into gh-134584-unicode
corona10 Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address code review
  • Loading branch information
@corona10
corona10 committed Jun 22, 2025
commit c90107976ada5b0473a79a98916a874140afb261
6 changes: 2 additions & 4 deletions Python/optimizer_bytecodes.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,15 +327,13 @@ dummy_func(void) {
goto error;
}
res = sym_new_const(ctx, temp);
l = left;
r = right;
Py_DECREF(temp);
}
else {
res = sym_new_type(ctx, &PyUnicode_Type);
l = left;
r = right;
}
l = left;
r = right;
}

op(_BINARY_OP_INPLACE_ADD_UNICODE, (left, right -- )) {
Expand Down
20 changes: 9 additions & 11 deletions Python/optimizer_cases.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading