Skip to content

gh-134584: Specialize POP_TOP by reference and type in JIT #135761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fidget-Spinner merged 9 commits into from
Jun 23, 2025
Merged

gh-134584: Specialize POP_TOP by reference and type in JIT #135761

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4b415f5
Specialize STORE_FAST by reference and type in JIT
Fidget-Spinner Jun 20, 2025
0031dfe
📜🤖 Added by blurb_it.
blurb-it[bot] Jun 20, 2025
ca6e42c
Address review
Fidget-Spinner Jun 20, 2025
4100934
Fix bugs
Fidget-Spinner Jun 20, 2025
c4121f5
Merge branch 'eliminate_store_fast_refcount' of github.com:Fidget-Spi…
Fidget-Spinner Jun 20, 2025
134ad1f
Address review
Fidget-Spinner Jun 22, 2025
23197eb
Remove _SWAP_FAST for now, only specialize POP_TOP
Fidget-Spinner Jun 23, 2025
9443007
fix naming
Fidget-Spinner Jun 23, 2025
a3b82a0
remove undeterministic test
Fidget-Spinner Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix naming
  • Loading branch information
@Fidget-Spinner
Fidget-Spinner committed Jun 23, 2025
commit 9443007af89fa3c53bf186087684d287df0219a9
8 changes: 4 additions & 4 deletions Lib/test/test_capi/test_opt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2349,7 +2349,7 @@ def testfunc(n):
assert ex is not None
"""))

def test_store_pop_top_specialize_none(self):
def test_pop_top_specialize_none(self):
def testfunc(n):
for _ in range(n):
global_identity(None)
Expand All @@ -2362,7 +2362,7 @@ def testfunc(n):

self.assertIn("_POP_TOP_NOP", uops)

def test_store_pop_top_specialize_int(self):
def test_pop_top_specialize_int(self):
def testfunc(n):
for _ in range(n):
global_identity(100000)
Expand All @@ -2375,7 +2375,7 @@ def testfunc(n):

self.assertIn("_POP_TOP_INT", uops)

def test_store_pop_top_specialize_float(self):
def test_pop_top_specialize_float(self):
def testfunc(n):
for _ in range(n):
global_identity(1e6)
Expand All @@ -2388,7 +2388,7 @@ def testfunc(n):

self.assertIn("_POP_TOP_FLOAT", uops)

def test_store_pop_top_specialize_str(self):
def test_pop_top_specialize_str(self):
def testfunc(n):
for _ in range(n):
global_identity("2" + "1")
Expand Down
Loading