Skip to content

GH-132983: Remove zstd version check in the header file #133502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hugovk merged 2 commits into from
May 6, 2025
Merged

GH-132983: Remove zstd version check in the header file #133502

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
baccfb9
Remove zstd version check in the header file
AA-Turner May 6, 2025
8b63a9e
Remove fallback symbol detection
AA-Turner May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Remove zstd version check in the header file
  • Loading branch information
@AA-Turner
AA-Turner committed May 6, 2025
commit baccfb9af8ff3224765438f08f7c563b09d4c1f3
8 changes: 0 additions & 8 deletions Modules/_zstd/_zstdmodule.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,6 @@ Python module.
#include "zdict.h"


// if you update the minimum version, you should update the compile
// check in configure.ac
#define PYTHON_MINIMUM_SUPPORTED_ZSTD_VERSION 10405

#if ZSTD_VERSION_NUMBER < PYTHON_MINIMUM_SUPPORTED_ZSTD_VERSION
#error "_zstd module requires zstd v1.4.5+"
#endif

/* Forward declaration of module state */
typedef struct _zstd_state _zstd_state;

Expand Down
Loading