Skip to content

gh-133141: Relax test_async_global_awaited_by to fix flakyness #133368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 3 commits into from
May 4, 2025
Merged

gh-133141: Relax test_async_global_awaited_by to fix flakyness #133368

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a3ba8dd
gh-133141: Fix race in test_async_global_awaited_by
pablogsal May 4, 2025
7190e86
Update Lib/test/test_external_inspection.py
pablogsal May 4, 2025
8e0b7dc
Update Lib/test/test_external_inspection.py
pablogsal May 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Lib/test/test_external_inspection.py
  • Loading branch information
@pablogsal
pablogsal authored May 4, 2025
commit 7190e867cfc4e177da8a0ecfd764324045d53c80
7 changes: 6 additions & 1 deletion Lib/test/test_external_inspection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,7 +532,12 @@ async def main():
expected_stack = [[['_aexit', '__aexit__', 'echo_client_spam'], ANY]]
tasks_with_stack = [task for task in entries if task[2] == expected_stack]
self.assertGreaterEqual(len(tasks_with_stack), 1000)
self.assertEqual([[['_aexit', '__aexit__', 'echo_client_spam'], ANY]], entries[-1][2])

# the final task will have some random number, but it should for
# sure be one of the echo client spam horde (In windows this is not true
# for some reason)
if sys.platform != "win32":
self.assertEqual([[['_aexit', '__aexit__', 'echo_client_spam'], ANY]], entries[-1][2])```
except PermissionError:
self.skipTest(
"Insufficient permissions to read the stack trace")
Expand Down
Loading