Skip to content

gh-133363: Fix Cmd completion for lines beginning with ! #133364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gaogaotiantian merged 4 commits into from
May 4, 2025
Merged

gh-133363: Fix Cmd completion for lines beginning with ! #133364

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
12e2495
Fix Cmd completion for lines beginning with `! `
godlygeek May 4, 2025
973bef6
Check falsiness instead
godlygeek May 4, 2025
1c6248e
Make news entry less descriptive
godlygeek May 4, 2025
c259bef
Test with and without a space after !
godlygeek May 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make news entry less descriptive
  • Loading branch information
@godlygeek
godlygeek committed May 4, 2025
commit 1c6248e427184be34f41011310099d40b76fdb4c
6 changes: 2 additions & 4 deletions Misc/NEWS.d/next/Library/2025-05-03-21-55-33.gh-issue-133363.PTLnRP.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
The :class:`cmd.Cmd` class has been fixed to call the ``completedefault``
The :class:`cmd.Cmd` class has been fixed to reliably call the ``completedefault``
method whenever the ``do_shell`` method is not defined and tab completion is
requested for a line beginning with ``!``. Previously ``completedefault``
was called only if there were no spaces between the ``!`` and the cursor
position where tab completion was attempted.
requested for a line beginning with ``!``.
Loading