Skip to content

gh-81793: Always call linkat() from os.link(), if available #132517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 13 commits into from
May 4, 2025
Merged

gh-81793: Always call linkat() from os.link(), if available #132517

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
a8f488a
gh-81793: Always call linkat() from os.link(), if available
serhiy-storchaka Apr 14, 2025
4ba224e
Fix typo and regenerate clinic files.
serhiy-storchaka Apr 14, 2025
5881b2a
Fix OpenIndiana.
serhiy-storchaka Apr 14, 2025
d2f233b
Fix test_inspect.
serhiy-storchaka Apr 14, 2025
95f55e3
Enable linkat().
serhiy-storchaka Apr 14, 2025
2eeb438
Apply suggestions from code review
serhiy-storchaka Apr 14, 2025
b4be526
Use subTest().
serhiy-storchaka Apr 15, 2025
80128e3
Disable linkat() on WASI.
serhiy-storchaka Apr 15, 2025
a45dfd9
Test how link() actually works on WASI.
serhiy-storchaka Apr 15, 2025
557f1ee
Revert "Test how link() actually works on WASI."
serhiy-storchaka Apr 15, 2025
b156f94
Merge branch 'main' into os-link-follow_symlinks
serhiy-storchaka Apr 21, 2025
2c436fb
Remove redundant checks for same type.
serhiy-storchaka Apr 21, 2025
0c7b16d
Merge branch 'main' into os-link-follow_symlinks
serhiy-storchaka May 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use subTest().
  • Loading branch information
@serhiy-storchaka
serhiy-storchaka committed Apr 15, 2025
commit b4be5269d76ecf29069eb66114a8ffbc183b0b53
64 changes: 34 additions & 30 deletions Lib/test/test_posix.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1523,43 +1523,47 @@ def test_pidfd_open(self):

@unittest.skipUnless(hasattr(os, "link"), "test needs os.link()")
def test_link_follow_symlinks(self):
default_follow = sys.platform.startswith(
('darwin', 'freebsd', 'netbsd', 'openbsd', 'dragonfly', 'sunos5'))
default_no_follow = sys.platform.startswith(('win32', 'linux'))
orig = os_helper.TESTFN
symlink = orig + 'symlink'
posix.symlink(orig, symlink)
self.addCleanup(os_helper.unlink, symlink)

link = orig + 'link'
posix.link(symlink, link)
self.addCleanup(os_helper.unlink, link)
default_follow = sys.platform.startswith(
('darwin', 'freebsd', 'netbsd', 'openbsd', 'dragonfly', 'sunos5'))
default_no_follow = sys.platform.startswith(('win32', 'linux'))
if os.link in os.supports_follow_symlinks or default_follow:
self.assertEqual(posix.lstat(link), posix.lstat(orig))
elif default_no_follow:
self.assertEqual(posix.lstat(link), posix.lstat(symlink))
with self.subTest('no follow_symlinks'):
# no follow_symlinks -> platform depending
link = orig + 'link'
posix.link(symlink, link)
self.addCleanup(os_helper.unlink, link)
if os.link in os.supports_follow_symlinks or default_follow:
self.assertEqual(posix.lstat(link), posix.lstat(orig))
elif default_no_follow:
self.assertEqual(posix.lstat(link), posix.lstat(symlink))

# follow_symlinks=False -> duplicate the symlink itself
link_nofollow = orig + 'link_nofollow'
try:
posix.link(symlink, link_nofollow, follow_symlinks=False)
except NotImplementedError:
if os.link in os.supports_follow_symlinks or default_no_follow:
raise
else:
self.addCleanup(os_helper.unlink, link_nofollow)
self.assertEqual(posix.lstat(link_nofollow), posix.lstat(symlink))
with self.subTest('follow_symlinks=False'):
# follow_symlinks=False -> duplicate the symlink itself
link = orig + 'link_nofollow'
try:
posix.link(symlink, link, follow_symlinks=False)
except NotImplementedError:
if os.link in os.supports_follow_symlinks or default_no_follow:
raise
else:
self.addCleanup(os_helper.unlink, link)
self.assertEqual(posix.lstat(link), posix.lstat(symlink))

# follow_symlinks=True -> duplicate the target file
link_following = orig + 'link_following'
try:
posix.link(symlink, link_following, follow_symlinks=True)
except NotImplementedError:
if os.link in os.supports_follow_symlinks or default_follow:
raise
else:
self.addCleanup(os_helper.unlink, link_following)
self.assertEqual(posix.lstat(link_following), posix.lstat(orig))
with self.subTest('follow_symlinks=True'):
# follow_symlinks=True -> duplicate the target file
link = orig + 'link_following'
try:
posix.link(symlink, link, follow_symlinks=True)
except NotImplementedError:
if os.link in os.supports_follow_symlinks or default_follow:
raise
else:
self.addCleanup(os_helper.unlink, link)
self.assertEqual(posix.lstat(link), posix.lstat(orig))


# tests for the posix *at functions follow
Expand Down
Loading