Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate typing.Text #92332

Closed
AlexWaygood opened this issue May 5, 2022 · 5 comments · Fixed by #92351
Closed

Deprecate typing.Text #92332

AlexWaygood opened this issue May 5, 2022 · 5 comments · Fixed by #92351
Labels
topic-typing type-feature A feature request or enhancement

Comments

@AlexWaygood
Copy link
Member

AlexWaygood commented May 5, 2022 •
edited
Loading

Feature or enhancement

The typing module has a huge API, and new features continue to be added in each version of Python. Deprecations should be done carefully and slowly, to minimise disruption for users, but we should nonetheless aim to shrink the API where features are no longer needed, so as to make the sheer size of the module less overwhelming for newcomers to Python typing.

Python 2.7 is now end-of-life, so typing.Text has no use anymore (its sole purpose was to provide backwards compatibility with Python 2). I propose that we should now deprecate typing.Text, with a view to eventually removing it.
@AlexWaygood AlexWaygood added type-feature A feature request or enhancement topic-typing labels May 5, 2022
@JelleZijlstra
Copy link
Member

I agree on deprecating Text and removing it from examples, but I don't want to remove it for a long time: that just needlessly breaks previously working code.

To reduce cognitive load on readers of the typing module docs, we can eventually move it to a separate section about deprecated names and cover it only briefly.

@AlexWaygood
Copy link
Member Author

I don't want to remove it for a long time: that just needlessly breaks previously working code.

We agree.

@Fidget-Spinner
Copy link
Member

Fidget-Spinner commented May 5, 2022 •
edited
Loading

Please forgive my ignorance: I didn't even know typing.Text existed. I don't think many people still use this, so we can deprecate it (but like you mentioned, remove it a long long time later).

@JelleZijlstra
Copy link
Member

It's pretty easy to miss :).

To be clear, by "a long time" I mean something like "wait a decade and then maybe start thinking about removing it". We shouldn't set a concrete removal timeline yet.

@AlexWaygood
Copy link
Member Author

It's pretty easy to miss :).

It's definitely not a big maintenance burden or anything!

@AlexWaygood AlexWaygood mentioned this issue May 5, 2022
Merged
Fidget-Spinner pushed a commit that referenced this issue May 6, 2022
@AlexWaygood @hauntsaninja
gh-92332: Docs-only deprecation of typing.Text (GH-92351)
6f18b86 
Co-authored-by: Shantanu <[email protected]>
sobolevn added a commit to sobolevn/py-pgproto that referenced this issue May 9, 2024
@sobolevn
typing.Text is deprecated
f936f80 
Use `str` instead. 
Source: 
- https://github.com/python/cpython/blob/35b5eaa176a5bae8a0cacb9c9f40ec948ecc4325/Lib/typing.py#L3419-L3420
- python/cpython#92332
@sobolevn sobolevn mentioned this issue May 9, 2024
Merged
msullivan pushed a commit to MagicStack/py-pgproto that referenced this issue May 9, 2024
@sobolevn
typing.Text is deprecated (#27)
4df3c26 
Use `str` instead. 
Source: 
- https://github.com/python/cpython/blob/35b5eaa176a5bae8a0cacb9c9f40ec948ecc4325/Lib/typing.py#L3419-L3420
- python/cpython#92332
@qew21 qew21 mentioned this issue Jun 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic-typing type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-92332: Docs-only deprecation of typing.Text AlexWaygood/cpython
3 participants
@JelleZijlstra @Fidget-Spinner @AlexWaygood