-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ANSI escape codes for colored output not handled correctly with pytest.fail(..., pytrace=False) #12959
Open
leonarduschen
wants to merge
8
commits into
pytest-dev:main
Choose a base branch
from
leonarduschen:fix-ansi-escape-code-for-fail-pytrace-false
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+32
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
(automation) changelog entry is part of PR
label
Nov 14, 2024
leonarduschen
changed the title
Fix ExcInfo.value printed as source code
Fix ANSI escape codes for colored output not handled correctly with pytest.fail(..., pytrace=False)
Nov 14, 2024
leonarduschen
commented
Nov 14, 2024
leonarduschen
commented
Nov 14, 2024
nicoddemus
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the PR, appreciate it!
nicoddemus
added
the
backport 8.3.x
apply to PRs at any point; backports the changes to the 8.3.x branch
label
Nov 21, 2024
Thanks @leonarduschen! Will squash/merge in a few days to give others a chance to review it. 👍 |
Sure thing @nicoddemus, thanks for the review! Excited for my first contribution :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport 8.3.x
apply to PRs at any point; backports the changes to the 8.3.x branch
bot:chronographer:provided
(automation) changelog entry is part of PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12849
Description:
ReprEntry.style == "value"
(happens when callingpytest.fail(..., pytrace=False)
, the message should not be printed to terminal usingTerminalWriter._write_source
because then it'll try to highlight the message as source codeTerminalWriter.line
orTerminalWriter.write
, I went with the later for testing purposes Fix ANSI escape codes for colored output not handled correctly with pytest.fail(..., pytrace=False) #12959 (comment)closes #XYZW
to the PR description and/or commits (whereXYZW
is the issue number). See the github docs for more information.changelog
folder, with a name like<ISSUE NUMBER>.<TYPE>.rst
. See changelog/README.rst for details.AUTHORS
in alphabetical order.