-
Notifications
You must be signed in to change notification settings - Fork 433
Stop using requests in favour of botocore & urllib3 #580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2dac834 to
c8fd4a1
Compare
aac47c6 to
32108d3
Compare
975db72 to
3e0517b
Compare
ikonst
reviewed
Apr 11, 2019
ikonst
reviewed
Apr 11, 2019
ikonst
reviewed
Apr 11, 2019
ikonst
reviewed
Apr 11, 2019
ikonst
reviewed
Apr 11, 2019
3e0517b to
2927fc7
Compare
ikonst
reviewed
Apr 12, 2019
ikonst
reviewed
Apr 12, 2019
ikonst
reviewed
Apr 12, 2019
ikonst
reviewed
Apr 12, 2019
ikonst
reviewed
Apr 12, 2019
ikonst
reviewed
Apr 12, 2019
d3864fe to
31324ae
Compare
6ed64ae to
69035f5
Compare
ikonst
approved these changes
Apr 16, 2019
69035f5 to
4b790d2
Compare
archlinux-github
pushed a commit
to archlinux/svntogit-community
that referenced
this pull request
Jan 29, 2021
* Cleanup dependencies
- python-dateutil: no longer needed after pynamodb/PynamoDB#850
- python-six & python-mock: no longer needed after pynamodb/PynamoDB#786
- python-requests: no longer needed after pynamodb/PynamoDB#580
(This is actually a change in 4.0, but I didn't review dependencies then)
* Update environment variables for testing
* Make tests less verbose
git-svn-id: file:///srv/repos/svn-community/svn@834674 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github
pushed a commit
to archlinux/svntogit-community
that referenced
this pull request
Jan 29, 2021
* Cleanup dependencies
- python-dateutil: no longer needed after pynamodb/PynamoDB#850
- python-six & python-mock: no longer needed after pynamodb/PynamoDB#786
- python-requests: no longer needed after pynamodb/PynamoDB#580
(This is actually a change in 4.0, but I didn't review dependencies then)
* Update environment variables for testing
* Make tests less verbose
git-svn-id: file:///srv/repos/svn-community/svn@834674 9fca08f4-af9d-4005-b8df-a31f2cc04f65
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using botocore's vendored
requestslibrary is becoming increasingly problematic. This moves to usingurllib3instead viabotocore, rather than managing therequestsversion directly and further diverging from thebotocoreimplementation.Breaking changes include:
session_clsorrequests_timeout_secondsconfigconnect_timeout_seconds,read_timeout_secondsandmax_pool_connectionsconfigrequestsexceptions.exc.causewas previously arequests.exceptions.ReadTimeout, it would now be abotocore.exceptions.ReadTimeoutError.Improvements:
before-sendbotocore hook to support testing via motoRelated: #558, #566, #559, #543, #569
Also related: boto/botocore#1486
Benchmarks
Here are some simple benchmarks using a dynalite server. Seems to be ~10% faster for the read/write path.