@moorepants So what I am understanding is that the rhs function is not checking if the dictionary p is the one with the constants and the dictionary r is the one with the specifieds.
The function seems to call convert_specifieds_dict_to_array().

def _convert_specifieds_dict_to_array(self, x, t, r):

        for k, v in r.items():
            # TODO : Not sure if this is the best check here.
            if (isinstance(type(k), UndefinedFunction) or
                isinstance(k, Derivative)):
                k = (k,)
            idx = [self.specifieds.index(symmy) for symmy in k]
            try:
                self._specifieds_values[idx] = v(x, t)
            except TypeError:  # not callable
                # If not callable, then it should be a float, ndarray,
                # or indexable.
                self._specifieds_values[idx] = v

        return self._specifieds_values

Even this function does not check if 'k' belongs to specifieds.
I think a simple check like
if(k in self.specifieds) should work.
Should I add this check and open a pull request?
I am not sure how to write a test case for this though.

The generated rhs function should check that the correct args are passed in. #181

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions