Sort globbed files for releases #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change simply sorts the list of files after the glob has been resolved. This is useful because these files are often destined for a release, and having to scroll through hundreds of files which aren't sorted is *painful*. I'm happy to convert this into an option that can be specified in the yaml if you'd prefer?
|
@umarcor I see no harm in this new behavior, so it doesn't need to be a parameter, right? |
|
Yeah no harm at all, just wasn't sure how strict you were gonna be about the O(nlogn) time to sort the array 😄. By way of an extra example, here's a release I've got. Trying to find the calendar But thanks for the GH action! it's solved so many issues I had previously. |
|
Is there anything preventing this from being merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change simply sorts the list of files after the glob has been resolved. This is useful because these files are often destined for a release, and having to scroll through hundreds of files which aren't sorted is painful.
New Features
None
Changes
Bug Fixes
None
I'm happy to convert this into an option that can be specified in the yaml if you'd prefer?