test: add a type test for p selectors (#12954)

puppeteer · Aug 14, 2024 · ceed58e · ceed58e
1 parent cc2eda2
commit ceed58e
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 0 deletions.
diff --git a/test-d/NodeFor.test-d.ts b/test-d/NodeFor.test-d.ts
@@ -104,6 +104,22 @@ declare const nodeFor: <Selector extends string>(
       nodeFor('ignored ignored > ignored + ignored | a#ignore')
     );
   }
+  {
+    expectType<HTMLAnchorElement>(nodeFor('custom-element >>> a'));
+    expectNotType<Element>(nodeFor('custom-element >>> a'));
+  }
+  {
+    expectType<Element>(nodeFor('div ::-p-text(world)'));
+    expectNotType<HTMLDivElement>(nodeFor('div ::-p-text(world)'));
+  }
+  {
+    expectType<HTMLDivElement>(nodeFor('div ::-p-text(world) >>>> div'));
+    expectNotType<Element>(nodeFor('div ::-p-text(world) >>>> div'));
+  }
+  {
+    expectType<HTMLAnchorElement>(nodeFor('a::-p-text(Hello)'));
+    expectNotType<Element>(nodeFor('a::-p-text(Hello)'));
+  }
 }
 {
   {

diff --git a/test/src/queryhandler.spec.ts b/test/src/queryhandler.spec.ts
@@ -379,6 +379,18 @@ describe('Query handler tests', function () {
       }
     });
 
+    it('should work with puppeteer pseudo classes', async () => {
+      const {server, page} = await getTestState();
+      await page.goto(`${server.PREFIX}/p-selectors.html`);
+      using element = await page.$('button::-p-text(world)');
+      assert(element, 'Could not find element');
+      expect(
+        await element.evaluate(element => {
+          return element.id === 'b';
+        })
+      ).toBeTruthy();
+    });
+
     it('should work with deep combinators', async () => {
       const {server, page} = await getTestState();
       await page.goto(`${server.PREFIX}/p-selectors.html`);