Update Mixin dashboard to editable: false #911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was reported by the mixtool lint: mixtool lint mixin.libsonnet [uneditable-dashboard] 'MySQL': Dashboard 'MySQL' is editable, it should be set to 'editable: false' Signed-off-by: Daniel Black <[email protected]>
rgeyer
approved these changes
Feb 13, 2025
Contributor
rgeyer
left a comment
rgeyer
left a comment
There was a problem hiding this comment.
LGTM. This is mostly a cosmetic/continuity rule. The result is that when it is imported into Grafana, the dashboard will be read-only by default.
It can, of course, be overwritten by a user with adequate permissions.
cristiangreco
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was reported by the mixtool lint:
mixtool lint mixin.libsonnet
[uneditable-dashboard] 'MySQL': Dashboard 'MySQL' is editable, it should be set to 'editable: false'
This is quick attempt at fixing the mixin CI error going by its error description. I haven't looked further on the implications of this.