-
Notifications
You must be signed in to change notification settings - Fork 806
fix binlog metrics on mysql 8.x #419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
SuperQ
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: rob <[email protected]>
|
@SuperQ Those tests seems unstable, every time different one fails, some with |
|
I'm going to adjust the Travis test setup to only run the integration test, rather than a full test as we do that in CircleCI. |
|
Hrm, that didn't help at all. I'm guessing there's something wrong with Travis right now. It's usually reliable. |
|
Retried the tests, looks like the Travis instability is fixed. |
Changes related to `replication_group_member_stats` collector: * metric "transaction_in_queue" was Counter instead of Gauge * renamed 3 metrics starting with `mysql_perf_schema_transaction_` to start with `mysql_perf_schema_transactions_` to be consistent with column names * exposing only server's own stats by matching MEMBER_ID with @@server_uuid resulting "member_id" label to be dropped. * [CHANGE] Switch to go-kit for logs. #433 * [BUGFIX] Fix binlog metrics on mysql 8.x #419 * [BUGFIX] Fix output value of wsrep_cluster_status #473 * [BUGFIX] Fix collect.info_schema.innodb_metrics for new field names (mariadb 10.5+) #494 * [BUGFIX] Fix log output of collect[] params #505 * [BUGFIX] Fix collect.info_schema.innodb_tablespaces for new table names #516 * [BUGFIX] Fix innodb_metrics for mariadb 10.5+ #523 * [BUGFIX] Allow perf_schema.memory summary current_bytes to be negative #517 * [ENHANCEMENT] Support heartbeats in UTC #471 * [FEATURE] Add `tls.insecure-skip-verify` flag to ignore tls verification errors #417 * [FEATURE] Add collector for AWS Aurora information_schema.replica_host_status #435 * [FEATURE] Add collector for `replication_group_members` #459 * [FEATURE] Add new metrics to `replication_group_member_stats` collector to support MySQL 8.x. #462 * [FEATURE] Add collector for `performance_schema.memory_summary_global_by_event_name` #515 * [FEATURE] Support authenticating using mTLS client cert and no password #539 Signed-off-by: Ben Kochie <[email protected]>
BREAKING CHANGES: Changes related to `replication_group_member_stats` collector: * metric "transaction_in_queue" was Counter instead of Gauge * renamed 3 metrics starting with `mysql_perf_schema_transaction_` to start with `mysql_perf_schema_transactions_` to be consistent with column names * exposing only server's own stats by matching MEMBER_ID with @@server_uuid resulting "member_id" label to be dropped. Changes: * [CHANGE] Switch to go-kit for logs. #433 * [FEATURE] Add `tls.insecure-skip-verify` flag to ignore tls verification errors #417 * [FEATURE] Add collector for AWS Aurora information_schema.replica_host_status #435 * [FEATURE] Add collector for `replication_group_members` #459 * [FEATURE] Add new metrics to `replication_group_member_stats` collector to support MySQL 8.x. #462 * [FEATURE] Add collector for `performance_schema.memory_summary_global_by_event_name` #515 * [FEATURE] Support authenticating using mTLS client cert and no password #539 * [ENHANCEMENT] Support heartbeats in UTC #471 * [BUGFIX] Fix binlog metrics on mysql 8.x #419 * [BUGFIX] Fix output value of wsrep_cluster_status #473 * [BUGFIX] Fix collect.info_schema.innodb_metrics for new field names (mariadb 10.5+) #494 * [BUGFIX] Fix log output of collect[] params #505 * [BUGFIX] Fix collect.info_schema.innodb_tablespaces for new table names #516 * [BUGFIX] Fix innodb_metrics for mariadb 10.5+ #523 * [BUGFIX] Allow perf_schema.memory summary current_bytes to be negative #517 Signed-off-by: Ben Kochie <[email protected]>
BREAKING CHANGES: Changes related to `replication_group_member_stats` collector: * metric "transaction_in_queue" was Counter instead of Gauge * renamed 3 metrics starting with `mysql_perf_schema_transaction_` to start with `mysql_perf_schema_transactions_` to be consistent with column names * exposing only server's own stats by matching MEMBER_ID with @@server_uuid resulting "member_id" label to be dropped. Changes: * [CHANGE] Switch to go-kit for logs. #433 * [FEATURE] Add `tls.insecure-skip-verify` flag to ignore tls verification errors #417 * [FEATURE] Add collector for AWS Aurora information_schema.replica_host_status #435 * [FEATURE] Add collector for `replication_group_members` #459 * [FEATURE] Add new metrics to `replication_group_member_stats` collector to support MySQL 8.x. #462 * [FEATURE] Add collector for `performance_schema.memory_summary_global_by_event_name` #515 * [FEATURE] Support authenticating using mTLS client cert and no password #539 * [ENHANCEMENT] Support heartbeats in UTC #471 * [BUGFIX] Fix binlog metrics on mysql 8.x #419 * [BUGFIX] Fix output value of wsrep_cluster_status #473 * [BUGFIX] Fix collect.info_schema.innodb_metrics for new field names (mariadb 10.5+) #494 * [BUGFIX] Fix log output of collect[] params #505 * [BUGFIX] Fix collect.info_schema.innodb_tablespaces for new table names #516 * [BUGFIX] Fix innodb_metrics for mariadb 10.5+ #523 * [BUGFIX] Allow perf_schema.memory summary current_bytes to be negative #517 Signed-off-by: Ben Kochie <[email protected]>
BREAKING CHANGES: Changes related to `replication_group_member_stats` collector: * metric "transaction_in_queue" was Counter instead of Gauge * renamed 3 metrics starting with `mysql_perf_schema_transaction_` to start with `mysql_perf_schema_transactions_` to be consistent with column names * exposing only server's own stats by matching MEMBER_ID with @@server_uuid resulting "member_id" label to be dropped. Changes: * [CHANGE] Switch to go-kit for logs. #433 * [FEATURE] Add `tls.insecure-skip-verify` flag to ignore tls verification errors #417 * [FEATURE] Add collector for AWS Aurora information_schema.replica_host_status #435 * [FEATURE] Add collector for `replication_group_members` #459 * [FEATURE] Add new metrics to `replication_group_member_stats` collector to support MySQL 8.x. #462 * [FEATURE] Add collector for `performance_schema.memory_summary_global_by_event_name` #515 * [FEATURE] Support authenticating using mTLS client cert and no password #539 * [FEATURE] Add TLS and basic authentication #522 * [ENHANCEMENT] Support heartbeats in UTC #471 * [ENHANCEMENT] Improve parsing of boolean strings #548 * [BUGFIX] Fix binlog metrics on mysql 8.x #419 * [BUGFIX] Fix output value of wsrep_cluster_status #473 * [BUGFIX] Fix collect.info_schema.innodb_metrics for new field names (mariadb 10.5+) #494 * [BUGFIX] Fix log output of collect[] params #505 * [BUGFIX] Fix collect.info_schema.innodb_tablespaces for new table names #516 * [BUGFIX] Fix innodb_metrics for mariadb 10.5+ #523 * [BUGFIX] Allow perf_schema.memory summary current_bytes to be negative #517 Signed-off-by: Ben Kochie <[email protected]>
Mysql 8.x returns 3 columns during
SHOW BINARY LOGSquery instead of 2 in older mysql.It fixes #413
It's based on @SuperQ comment in #390