Explicitly number the sections of the charter. #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he Storage standard as one of its destinations.
charter.html
Outdated
| if (elementWithID instanceof HTMLHeadingElement) { | ||
| const headingLevel = parseInt(elementWithID.localName.substring(1), 10); | ||
| sectionCounters[headingLevel]++; | ||
| for (let i = headingLevel+1; i < 7; i++) { |
Member
There was a problem hiding this comment.
Consider replacing lines 700 through 706 with:
sectionCounters.fill(0, headingLevel + 1);
let sectionNumber = sectionCounters.slice(0, headingLevel + 1).filter(item=> item != 0);
The slice call is actually not necessary but may make the intent more clear to the reader.
erik-anderson
approved these changes
Jul 9, 2021
Member
erik-anderson
left a comment
erik-anderson
left a comment
There was a problem hiding this comment.
Looks good. The change suggested in my comment is optional.
Contributor
martinthomson
left a comment
martinthomson
left a comment
There was a problem hiding this comment.
Any reason we shouldn't merge this? With Erik's tweak, this seems pretty useful to me.
| let sectionCounters = [NaN, 0, 0, 0, 0, 0, 0]; | ||
| document.querySelectorAll("[id]").forEach(function(elementWithID) { | ||
| const permalink = document.createElement("a"); | ||
| permalink.href = "#" + elementWithID.getAttribute("id"); |
Contributor
There was a problem hiding this comment.
I realize that this has been sitting here awhile, but maybe this could be made absolute by starting with document.querySelector("#about+ul li a").href (or a simpler query if you tag that element more directly, as I think we should). Then the permalink is much closer to perma.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't contain any normative or functional changes, merely aesthetic ones.