Skip to content

Conversation

@hober
Copy link
Member

@hober hober commented Feb 12, 2020

My attempt to address #11.

  • Further clarify the relationships of Proposals, Work Items, and Community Group Reports.
  • Fix a typo
  • Clarify that the feature addition and removal rules apply to Work Items, not Proposals.

@hober hober added charter do not merge This PR is a work in progress and is not ready to be merged labels Feb 12, 2020
@hober
Copy link
Member Author

hober commented Feb 12, 2020

I'd appreciate your eyes on this, @jyasskin.

@hober hober changed the title Define the artifacts of Proposals and Work Items. Fixes #11. Define the artifacts of Proposals and Work Items. Feb 12, 2020
Copy link
Member

@TanviHacks TanviHacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me.

Copy link
Contributor

@jyasskin jyasskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this says what you want it to say, but I left several nits that might help improve the precision or clarity.

I don't think it's a good idea to try to use the lack of a precise specification as the way to tell developers that an idea isn't supported by multiple implementers. A precise specification can help implementers make the decision of whether they support the idea, and we shouldn't handicap proposals from non-browser-vendors by making them prove themselves with just the explainer.

However, if the CG in general does want to pick that as the mechanism, it's better to have it written down, as this PR does, than not.

@hober hober force-pushed the issue-11 branch 2 times, most recently from 756e885 to 4ffa850 Compare March 24, 2020 00:44
@hober hober requested a review from TanviHacks March 24, 2020 00:45
@hober
Copy link
Member Author

hober commented Mar 24, 2020

@jyasskin wrote:

I think this says what you want it to say, but I left several nits that might help improve the precision or clarity.

Thanks for these!

I've rebased this and refined the wording quite a lot based on @jyasskin's excellent review feedback. Please take another look, @TanviHacks, @erik-anderson, and @jyasskin.

@hober
Copy link
Member Author

hober commented Mar 24, 2020

Rebased again, since #19 landed.

as defined in the
<a href=https://www.w3.org/community/about/agreements/>Community and
Business Group Process</a>—a special kind of Community Group Report
whose purpose is to enable interoperability between independent

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"--a special kind of CGR whose purpose is to enable interop between indep. impl. of the feature it defines."

I guess this clarity differentiates this CG's "specifications" from other potential types of specifications, but was anyone actually confused about this point?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was my attempt to preserve @martinthomson's change from #19. I'd be happy to tweak this further, if you have a suggestion.

@hober
Copy link
Member Author

hober commented Mar 30, 2020

I've landed a couple of tweaks based on @travisleithead's review. @TanviHacks @erik-anderson, please take a look. I'd like to land this soon.

@hober hober changed the title Define the artifacts of Proposals and Work Items. Work Items are CGRs and Specifications as defined in the CBGP. Proposals are CGRs but not Specifications. Fixes #11. Mar 30, 2020
Copy link

@dbaron dbaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of this looks like great clarification. I have a few minor comments, and in the middle one more substantive one.

@hober
Copy link
Member Author

hober commented Apr 1, 2020

Rebased now that #21 has landed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

charter do not merge This PR is a work in progress and is not ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants