Skip to content

[React] Add fill prop #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 26, 2021
Merged

[React] Add fill prop #551

merged 4 commits into from
Feb 26, 2021

Conversation

colebemis
Copy link
Contributor

Problem

Our octicon components don't provide a way to change the fill attribute of the underlying SVG.

Solution

This PR adds a fill prop to all octicon components. @macno originally implemented this in #418 but merge conflicts made that PR difficult to merge.

Co-authored-by: @macno

@vercel
Copy link

vercel bot commented Feb 23, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/octicons/H8en25ojRNdW1xiR1ECvajub1oe2
✅ Preview: https://octicons-git-cb-fill-prop-primer.vercel.app

@colebemis colebemis mentioned this pull request Feb 23, 2021
Closed
@vercel vercel bot temporarily deployed to Preview February 23, 2021 19:14 Inactive
@colebemis colebemis requested a review from jonrohan February 23, 2021 19:16
jonrohan
jonrohan reviewed Feb 24, 2021
View reviewed changes
Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly want to know what others think about adding fill. Does this mean someone will be able to color the icon with fill and with color props?

@colebemis
Copy link
Contributor Author

@jonrohan Our components don't currently accept a color prop. Right now, the only ways to change the color of an icon with the React library is to style an icon with CSS or change the color of a parent element.

@colebemis colebemis changed the base branch from master to release-12.1.0 February 26, 2021 17:10
@colebemis colebemis merged commit 8a7140a into release-12.1.0 Feb 26, 2021
@colebemis colebemis deleted the cb/fill-prop branch February 26, 2021 17:11
@colebemis colebemis mentioned this pull request Feb 26, 2021
Merged
2 tasks
@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Closed
@renovate renovate bot mentioned this pull request Aug 2, 2021
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonrohan jonrohan jonrohan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colebemis @jonrohan