Rename icon assets #465
Rename icon assets #465
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/octicons/je1ft2ymz |
|
Hi all, I have just updated this PR with changes for a couple of other icons that had inconsistent names.
Both of these now match the name in However, I would note that Best, |
There was a problem hiding this comment.
Thanks for fixing these names, @BenJetson! 🙇
@ashygee I'd call this a patch release even though renaming icons is technically a breaking change. I consider these name changes to be bug fixes. However, if someone feels strongly about this being a major release, I could be convinced (cc @joelhawksley).
When we release this, we will have to update one usage of unverifed (typo) in dotcom: https://github.com/github/github/blob/master/app/views/businesses/security_settings/team_sync/_settings_unsupported.html.erb#L3
|
@colebemis this should be a major release, due to the breaking API changes 👍 |
Greetings, Octicons maintainers!
I was writing a small library that uses Octicons today and noticed a couple of small problems with your file names.
Firstly, I corrected this typo:
unverifed-24.svg→unverified-24.svg.Secondly, I renamed
file-symlink-24.svg→file-symlink-file-24.svg.The goal of the second rename is to make the names more consistent. The smaller asset was already named
file-symlink-file-16.svgand the entry inkeywords.jsonis forfile-symlink-file.Let me know if I need to update these names elsewhere in the repository. I did a global search and didn't see any references, so I think the rename is sufficient.
Cheers,
Ben