Deprecate variables in 14.0.0 #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/primer/primer-css/kzjd0xkqr |
This was referenced Dec 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This formally deletes the following variable declarations:
$marketingSpacersand$allSpacers(use$marketing-spacersand$marketing-all-spacersinstead)$status-pending$repo-private-text,$repo-private-bg, and$repo-private-icon$highlight-yellow$exploregrid-item-border-radius$stats-switcher-py$stats-viewport-height$min_tab_size,$max_tab_sizeI also had to make two fixes on the tool side:
script/dist.jsnow includes marketing variablesdist/variables.json(so that we can compare them inscript/test-deprecations.js)script/test-deprecations.jsdoesn't throw an error if a variable that was supposed to be deprecated and doesn't exist in the most recent version of Primer. This is the case with all of our marketing variables, because we weren't previously publishing marketing variable data. 😬