Add default background-color to SideNav #873
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a default
background-color
to the.SideNav
component.Reasoning
The main reason is to make the linter pass. 😇 Currently in our documentation we have:
But that causes an
The following CSS classes were used in class attributes but have no style rules referencing them
error when used on .com. We could removeSideNav
from the markup, but that feels very strange, not having a "main" class name and only use child class names.So we need "some" property that we can use (
.SideNav { ??? }
). Addingbackground-color
seems to make the most sense since we typically use a light gray background for Side Navs.