Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump @primer/gatsby-theme-doctocat from 3.1.1 to 4.0.0 in /docs #2191

Merged
merged 9 commits into from
Aug 19, 2022
Merged

Bump @primer/gatsby-theme-doctocat from 3.1.1 to 4.0.0 in /docs #2191

merged 9 commits into from
Aug 19, 2022

Conversation

josepmartins
Copy link
Contributor

@josepmartins josepmartins commented Aug 1, 2022 •
edited
Loading

What are you trying to accomplish?

  • Bump Doctocat for a consistent reader experience when navigating between different implementation doc sites.
  • Move section titles as Introduction NavItems in the Sidebar

Screenshot 2022-08-04 at 14 46 21

Reference

Can these changes ship as is?

  • Yes, this PR does not depend on additional changes. 🚢

@josepmartins josepmartins requested a review from a team as a code owner August 1, 2022 08:09
@changeset-bot
Copy link

changeset-bot bot commented Aug 1, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: d60a328

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@josepmartins josepmartins temporarily deployed to github-pages August 1, 2022 08:15 Inactive
@github-actions github-actions bot temporarily deployed to Storybook Preview August 1, 2022 08:16 Inactive
@josepmartins josepmartins temporarily deployed to github-pages August 1, 2022 08:24 Inactive
@github-actions github-actions bot temporarily deployed to Storybook Preview August 1, 2022 08:25 Inactive
@josepmartins josepmartins mentioned this pull request Aug 1, 2022
Merged
@josepmartins josepmartins marked this pull request as draft August 1, 2022 12:36
This was referenced Aug 1, 2022
Merged
Closed
Merged
Merged
@josepmartins josepmartins temporarily deployed to github-pages August 4, 2022 12:51 Inactive
@github-actions github-actions bot temporarily deployed to Storybook Preview August 4, 2022 12:52 Inactive
@josepmartins
Copy link
Contributor Author

josepmartins commented Aug 4, 2022 •
edited
Loading

I moved the old titles to new NavItems and change its label to Introduction. WDYT @langermank @lesliecdubs? I even thought of changing the page title to use "{SectionName} introduction" to be aligned with the navigation label.

Screenshot 2022-08-04 at 13 51 53

@josepmartins josepmartins marked this pull request as ready for review August 4, 2022 12:53
@josepmartins josepmartins requested review from lesliecdubs, siddharthkp and langermank and removed request for lesliecdubs August 4, 2022 12:53
lesliecdubs
lesliecdubs approved these changes Aug 10, 2022
View reviewed changes
Copy link
Member

@lesliecdubs lesliecdubs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change to the section titles looks good to me! Nice update.

Note that I'm also adding @colebemis as an additional reviewer on this PR given his experience with our Doctocat theme, and he may want to put some quick eyes on the dependency changes happening here.

@josepmartins josepmartins removed the request for review from langermank August 10, 2022 15:01
@josepmartins josepmartins temporarily deployed to github-pages August 10, 2022 15:07 Inactive
@github-actions github-actions bot temporarily deployed to Storybook Preview August 10, 2022 15:08 Inactive
@jonrohan jonrohan closed this Aug 11, 2022
@jonrohan jonrohan reopened this Aug 11, 2022
@jonrohan
Copy link
Member

Sorry wrongfully closed 🙇🏻

@github-actions github-actions bot temporarily deployed to Storybook Preview August 11, 2022 16:10 Inactive
@josepmartins josepmartins temporarily deployed to github-pages August 11, 2022 16:15 Inactive
@github-actions github-actions bot temporarily deployed to Storybook Preview August 11, 2022 16:15 Inactive
@josepmartins josepmartins temporarily deployed to github-pages August 16, 2022 11:51 Inactive
@github-actions github-actions bot temporarily deployed to Storybook Preview August 16, 2022 11:52 Inactive
@josepmartins josepmartins temporarily deployed to github-pages August 18, 2022 07:52 Inactive
@github-actions github-actions bot temporarily deployed to Storybook Preview August 18, 2022 07:52 Inactive
colebemis
colebemis approved these changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Thank you, @josepmartins!

@josepmartins josepmartins temporarily deployed to github-pages August 19, 2022 08:05 Inactive
@github-actions github-actions bot temporarily deployed to Storybook Preview August 19, 2022 08:06 Inactive
@github-actions github-actions bot temporarily deployed to Storybook Preview August 19, 2022 08:23 Inactive
@josepmartins josepmartins merged commit e175f69 into main Aug 19, 2022
@josepmartins josepmartins deleted the bump-doctocat-4.0.0 branch August 19, 2022 08:46
@primer-css primer-css mentioned this pull request Aug 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colebemis colebemis colebemis approved these changes

@lesliecdubs lesliecdubs lesliecdubs approved these changes

Assignees
No one assigned
Labels
patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@josepmartins @jonrohan @lesliecdubs @colebemis