NavigationList #1905
Merged
NavigationList #1905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 428d00f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
langermank
commented
Feb 9, 2022
| @@ -157,98 +150,6 @@ | |||
| } | |||
| } | |||
|
|
|||
| // collapsible item [aria-expanded] | |||
|
|
|||
| // nesting (single level) | |||
There was a problem hiding this comment.
Moving all collapse logic down a level to -content
jonrohan
reviewed
Feb 9, 2022
vdepizzol
reviewed
Feb 9, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing a11y feedback
This is a working PR to provide pre-release CSS for dotcom. We'll use
NavigationListstories as a template for the View Component implementation.<button>to manage collapsible groups (instead of handling it on the<li>)Dividermarkup including anh3tag withidreferenced byarialabelledbyidper groupBreaking changes
ActionList-sectionDivider-titlenew class for title<h3>.ActionList-item--hasActiveSubItemActionList-content--hasActiveSubItemstatelogic moved down one level to thebuttonakaActionList-contentbuttonoverrides to remove default browser stylingStorybook changes
ActionListand co to a new directory calledUI Patternswhich is intended to be used for private api (the building blocks of other components)ActionListunderComponentsto demonstrate a list of links scenarioNavigationListandTreeViewas separate components underComponentsReview
Feel free to skip reviewing the
.stories.jsxchanges, it's purely organizational changes and refactoring to make sharing stories easier.ActionList--treevariant