-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Marketing: add link components #1807
Conversation
🦋 Changeset detectedLatest commit: 3923ea6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great! Some minor notes 👀 I think if we fix that + add some documentation and outline the different variants in the documentation, I think this is ✨👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed the same and tried to investigate what is the reason - it has something to do with the custom web font we use in marketing. We have agreed to work on it in a separate PR. |
github/github
, while doing slight refactoring.Fixes https://github.com/github/site-design/issues/1417