Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marketing: add link components #1807

Merged
merged 39 commits into from
Dec 6, 2021
Merged

Conversation

enstyled
Copy link
Contributor

@enstyled enstyled commented Dec 2, 2021

  • Upstreaming the marketing link component from github/github, while doing slight refactoring.
  • Extracting a reusable animated arrow utility
  • Reuse the animated arrow in marketing buttons

Fixes https://github.com/github/site-design/issues/1417

@changeset-bot
Copy link

changeset-bot bot commented Dec 2, 2021

🦋 Changeset detected

Latest commit: 3923ea6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@tobiasahlin tobiasahlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great! Some minor notes 👀 I think if we fix that + add some documentation and outline the different variants in the documentation, I think this is ✨👌

Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, not blocking if this is more of a move-code-to-primer PR :)

I'm also curious, is the padding on marketing buttons intentionally uneven?
image
image

@enstyled
Copy link
Contributor Author

enstyled commented Dec 3, 2021

I'm also curious, is the padding on marketing buttons intentionally uneven?

Noticed the same and tried to investigate what is the reason - it has something to do with the custom web font we use in marketing. We have agreed to work on it in a separate PR.

@tobiasahlin tobiasahlin enabled auto-merge (squash) December 6, 2021 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants