Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the duplicate deprecation backgrounds #1663

Merged
merged 2 commits into from
Oct 8, 2021

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Oct 8, 2021

This fixes a bug introduced in #1661 where we're suggesting people replace deprecated classes with themselves.

I also added a test so we don't make the same mistake twice.

/cc @primer/css-reviewers

@jonrohan jonrohan requested a review from a team as a code owner October 8, 2021 16:18
@jonrohan jonrohan requested a review from simurai October 8, 2021 16:18
@changeset-bot
Copy link

changeset-bot bot commented Oct 8, 2021

🦋 Changeset detected

Latest commit: 492d5d1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jonrohan jonrohan removed the request for review from simurai October 8, 2021 16:18
@jonrohan jonrohan merged commit 87b0b1d into main Oct 8, 2021
@jonrohan jonrohan deleted the fix_deprecation_duplicates branch October 8, 2021 16:20
@primer-css primer-css mentioned this pull request Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant