Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .wb-break-word class to existing .break-word #1555

Merged
merged 6 commits into from
Aug 31, 2021
Merged

Conversation

jonrohan
Copy link
Member

This adds wb-break-word class to Primer to match the wb-break-all class format that we already have. This will enable primer/view_components to have a :break_word argument. Because in view_components these classes are pulled in and need a consistent naming scheme.

In the next major release we should remove .break-word

@jonrohan jonrohan requested a review from a team as a code owner August 29, 2021 16:00
@jonrohan jonrohan requested a review from simurai August 29, 2021 16:00
@changeset-bot
Copy link

changeset-bot bot commented Aug 29, 2021

🦋 Changeset detected

Latest commit: 0c57bd8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jonrohan jonrohan enabled auto-merge (squash) August 31, 2021 00:41
@jonrohan jonrohan merged commit 4ae2174 into main Aug 31, 2021
@jonrohan jonrohan deleted the wb-break-word branch August 31, 2021 00:42
@primer-css primer-css mentioned this pull request Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants