Convert package to a ES module #1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9ba3df1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
As far as I can tell the JSON outputted is fine? Not sure why I'm getting that error. |
jonrohan
approved these changes
Aug 11, 2021
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As dependencies start publishing as pure ES modules, it will become increasingly difficult to update those dependencies. For that reason, we should convert the
@primer/cssto an ES module. This pull request is my stab at it.I don't work on this project a lot, so that I might break something not apparent to me. I would appreciate any help in making sure everything is still working correctly.
References
#1515
closes #1516
https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c