Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

render code at 100% font size irregardless of direct descension #1525

Merged
merged 2 commits into from
Aug 5, 2021

Conversation

joelhawksley
Copy link
Contributor

This change fixes a bug when rendering markdown and there are outputs where <code> tags get rendered at 85% font-size when not a direct descendant of a <pre>.

Before:

127915129-54e72d4d-495d-4f4c-aee5-962fecc9205d

After:

Screen Shot 2021-08-04 at 11 17 05 AM

/cc @primer/ds-core

@changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2021

🦋 Changeset detected

Latest commit: 6193f0e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@joelhawksley joelhawksley marked this pull request as draft August 4, 2021 22:56
Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked this out on https://primer-css-azspe2agy-primer.vercel.app/css/components/markdown tinkering with the html in devtools looks fixed 👍🏻

@joelhawksley joelhawksley marked this pull request as ready for review August 5, 2021 16:18
@joelhawksley joelhawksley merged commit 06f8362 into main Aug 5, 2021
@joelhawksley joelhawksley deleted the code-within-code branch August 5, 2021 16:18
@primer-css primer-css mentioned this pull request Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants