Component refresh 7 #1077
Merged
Component refresh 7 #1077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primer-css/q8bfva7ps |
auareyou
approved these changes
May 6, 2020
This was referenced Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few more "Component refresh" tweaks.
States
.State--greennow uses the default$bg-greencolor. 👀 PreviewThis should make it match other components like that timeline check:
Pagination
The "Previous" and "Next" buttons now have the chevron icons "backed in" with CSS-only. It uses
clip-path: polygon()to draw the shape. 👀 PreviewThe
clip-path: polygon()is generated by converting the Octicon with this tool. It can't draw curves, so the shape is not as rounded as when using the icon as SVG, but maybe still close enough?The benefit is no changes are needed to dotcom. But after the refresh we can refactor it and switch to the real Octicons.
Flash alerts
In #1071 the flash alerts have a padding of
24px. That looked great stand-alone, but didn't align with a component like.Box:So this PR changes the side padding back to
16px:👀 Preview