Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vue: fix format on blocks with src attribute #9052

Merged
merged 4 commits into from
Aug 25, 2020
Merged

Vue: fix format on blocks with src attribute #9052

merged 4 commits into from
Aug 25, 2020

Conversation

fisker
Copy link
Member

@fisker fisker commented Aug 25, 2020

Fixes #9049

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/pr-XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@fisker fisker changed the title Vue: fix template format for external files Vue: fix format on blocks with src attribute Aug 25, 2020
@fisker fisker marked this pull request as ready for review August 25, 2020 11:36
@fisker fisker mentioned this pull request Aug 25, 2020
Closed
6 tasks
@fisker fisker merged commit 073dfd9 into prettier:master Aug 25, 2020
@fisker fisker deleted the vue-plugins branch August 25, 2020 15:06
@thorn0
Copy link
Member

thorn0 commented Aug 25, 2020

Even though it might be not very useful code, this looks strange:

Prettier pr-9052
Playground link

--parser vue

Input:

<custom lang="markdown" />

Output:

<custom lang="markdown"

/>

@fisker
Copy link
Member Author

fisker commented Aug 25, 2020

I'll send another PR for this.

@fisker fisker mentioned this pull request Aug 25, 2020
Merged
4 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sosukesuzuki sosukesuzuki sosukesuzuki approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vue template with src not well formatted when installed a plugin that transforms the template tag's content (since 2.1.0)
5 participants
@fisker @thorn0 @alexander-akait @Shinigami92 @sosukesuzuki