Revert "markdown: fix redundant leading spaces in markdown list" #7847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
approved these changes
Mar 23, 2020
sosukesuzuki
approved these changes
Mar 23, 2020
|
How about adding a test with this markdown content, just in case? <!-- see https://github.com/prettier/prettier/issues/7846 -->
- a a
b b
c c
d d
e e
1. a a a
b b b
c c c
d d d
e e e |
|
Thanks for that! Seems like there are conflicts with master (CI checks cannot kick off) |
|
There is no conflicts, but we might have broken something in #7824 |
thorn0
force-pushed
the
revert-7178-fix/#6948
branch
from
4449140
to
a2bdadd
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #7178
fixes #7846
reopens #6948
see #7846 (comment)