Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved multiline closure comment detection #6070

Merged
merged 2 commits into from
May 7, 2019
Merged

Improved multiline closure comment detection #6070

merged 2 commits into from
May 7, 2019

Conversation

yangsu
Copy link
Contributor

@yangsu yangsu commented Apr 18, 2019 •
edited
Loading

Fixes #6067

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If the change is user-facing) I’ve added my changes to the CHANGELOG.unreleased.md file following the template.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@alexander-akait
Copy link
Member

Something wrong with CI

@j-f1
Copy link
Member

j-f1 commented Apr 18, 2019

Restarted the CI.

@j-f1
Copy link
Member

j-f1 commented Apr 20, 2019

Looks like the changelog didn’t get updated. Can you add an entry for this change?

@yangsu
Copy link
Contributor Author

yangsu commented Apr 22, 2019

oops. will do

@duailibe duailibe merged commit 54b7655 into prettier:master May 7, 2019
@duailibe
Copy link
Member

duailibe commented May 7, 2019

Thank you!

@xcomponentadmin xcomponentadmin mentioned this pull request May 13, 2019
Closed
@automatops automatops mentioned this pull request May 13, 2019
Merged
1 task
This was referenced Jun 5, 2019
Merged
Merged
Closed
Merged
Merged
Closed
Closed
Closed
Merged
Merged
Closed
Closed
Closed
Merged
Merged
Open
Closed
This was referenced Jun 6, 2019
Closed
Merged
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Aug 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@j-f1 j-f1 j-f1 approved these changes

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Closure Compiler type cast issues with multiline comments
4 participants
@yangsu @alexander-akait @j-f1 @duailibe