Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(javascript): add missing parens for binary in optionalMember #5543

Merged
merged 6 commits into from
Nov 25, 2018
Merged

fix(javascript): add missing parens for binary in optionalMember #5543

merged 6 commits into from
Nov 25, 2018

Conversation

ikatyang
Copy link
Member

Fixes #5535

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

j-f1
j-f1 approved these changes Nov 24, 2018
View reviewed changes
Copy link
Member

@j-f1 j-f1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(off-topic) @ikatyang do you have access to the Prettier site on Netlify? If so, could I have access?

@ikatyang
Copy link
Member Author

I've changed Netlify to use the GitHub App instead of webhooks but it seems it's still not accessible for people with write access. I guess we're probably under a personal plan but we could change it to use a free open source plan with team support. (I cannot access the plan info so I'm not sure.)

cc @azz

@ikatyang ikatyang added this to the 1.15.3 milestone Nov 25, 2018
@ikatyang ikatyang merged commit c788842 into prettier:master Nov 25, 2018
@ikatyang ikatyang deleted the fix/javascript/parens-for-binary-in-optional-member branch November 25, 2018 03:42
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Feb 23, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@j-f1 j-f1 j-f1 approved these changes

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Milestone
1.15.3
Development

Successfully merging this pull request may close these issues.
3 participants
@ikatyang @alexander-akait @j-f1