Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(css-in-js): do not duplicate comments #5416

Merged
merged 2 commits into from
Nov 10, 2018
Merged

fix(css-in-js): do not duplicate comments #5416

merged 2 commits into from
Nov 10, 2018

Conversation

ikatyang
Copy link
Member

@ikatyang ikatyang commented Nov 9, 2018

Fixes #5381

The original behavior was introduced by #5240. Since the original intent is to keep line breaks so I guess we can simply preserve at most 2 line breaks (next empty line)?

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@ikatyang ikatyang added this to the 1.15.2 milestone Nov 9, 2018
@ikatyang ikatyang merged commit cc6899e into prettier:master Nov 10, 2018
@ikatyang ikatyang deleted the fix/css-in-js/no-duplicate-commment branch November 10, 2018 08:44
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Feb 8, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Milestone
1.15.2
Development

Successfully merging this pull request may close these issues.
2 participants
@ikatyang @alexander-akait