Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(markdown): better handling for trailing spaces #4593

Merged
merged 1 commit into from
Jun 7, 2018
Merged

fix(markdown): better handling for trailing spaces #4593

merged 1 commit into from
Jun 7, 2018

Conversation

ikatyang
Copy link
Member

  • preserve trailing spaces in html, excluding html comment
  • doc-printer is now unrelated to options.parser
  • fix some cases that two trailing spaces are mis-considered as break

@ikatyang
Copy link
Member Author

ikatyang commented Jun 5, 2018

Does anyone want to take a look at this?

@j-f1 j-f1 requested review from duailibe and azz June 5, 2018 16:27
@duailibe
Copy link
Member

duailibe commented Jun 5, 2018

Sorry this went unnoticed

@ikatyang ikatyang merged commit 35a42be into prettier:master Jun 7, 2018
@ikatyang ikatyang deleted the fix/markdown-trailing-space branch June 7, 2018 16:20
bors bot referenced this pull request in mozilla/delivery-console Jun 8, 2018
@bors @renovate-bot
Merge #185
65d1c53 
185: Update dependency prettier to v1.13.5 r=rehandalal a=renovate[bot]

This Pull Request updates dependency [prettier](https://github.com/prettier/prettier) from `v1.13.4` to `v1.13.5`



<details>
<summary>Release Notes</summary>

### [`v1.13.5`](https://github.com/prettier/prettier/blob/master/CHANGELOG.md#&#8203;1135)
[Compare Source](prettier/prettier@1.13.4...1.13.5)
[link](prettier/prettier@1.13.4...1.13.5)

- Better handling of trailing spaces in Markdown ([#&#8203;4593](`https://github.com/prettier/prettier/pull/4593`))
- Fix empty file error in JSON and GraphQL ([#&#8203;4553](`https://github.com/prettier/prettier/pull/4553`))
- Preserve decorator on TypeScript interfaces ([#&#8203;4632](`https://github.com/prettier/prettier/pull/4632`))
- Inline \_ or $ in the root of a method chain ([#&#8203;4621](`https://github.com/prettier/prettier/pull/4621`))

---

</details>




---

This PR has been generated by [Renovate Bot](https://renovatebot.com).

Co-authored-by: Renovate Bot <[email protected]>
peterbe referenced this pull request in mozilla-services/tecken Jun 22, 2018
@renovate
Update dependency prettier to v1.13.5 (#906)
9bb42c3 
This Pull Request updates dependency [prettier](https://github.com/prettier/prettier) from `v1.13.4` to `v1.13.5`



<details>
<summary>Release Notes</summary>

### [`v1.13.5`](https://github.com/prettier/prettier/blob/master/CHANGELOG.md#&#8203;1135)
[Compare Source](prettier/prettier@1.13.4...1.13.5)
[diff](prettier/prettier@1.13.4...1.13.5)

- Better handling of trailing spaces in Markdown ([#&#8203;4593](`https://github.com/prettier/prettier/pull/4593`))
- Fix empty file error in JSON and GraphQL ([#&#8203;4553](`https://github.com/prettier/prettier/pull/4553`))
- Preserve decorator on TypeScript interfaces ([#&#8203;4632](`https://github.com/prettier/prettier/pull/4632`))
- Inline \_ or $ in the root of a method chain ([#&#8203;4621](`https://github.com/prettier/prettier/pull/4621`))

---

</details>




---

This PR has been generated by [Renovate Bot](https://renovatebot.com).
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Sep 5, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Sep 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@duailibe duailibe duailibe approved these changes

@azz azz Awaiting requested review from azz

Assignees
No one assigned
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ikatyang @duailibe