Skip to content

chore(deps): update dependency file-entry-cache to v10 #16725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fisker merged 14 commits into from
Jan 17, 2025
Merged

chore(deps): update dependency file-entry-cache to v10 #16725

fisker merged 14 commits into from
Jan 17, 2025

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Oct 8, 2024 •
edited
Loading

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
file-entry-cache (source) 9.1.0 -> 10.0.5 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the warning logs for more information.

Configuration

📅 Schedule: Branch creation - "after 01:00 on sunday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the dependency Dependency Upgrade label Oct 8, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024 •
edited
Loading

Size Change: +24.5 kB (+0.31%)

Total Size: 7.87 MB

Filename Size Change
./dist/internal/cli.mjs 145 kB +20.7 kB (+16.64%) ⚠️
./dist/LICENSE 210 kB +3.82 kB (+1.86%)
ℹ️ View Unchanged
Filename Size
./dist/bin 4.1 kB
./dist/bin/prettier.cjs 2.24 kB
./dist/doc.d.ts 7.42 kB
./dist/doc.js 53.1 kB
./dist/doc.mjs 49.6 kB
./dist/index.cjs 36.8 kB
./dist/index.d.ts 26.9 kB
./dist/index.mjs 740 kB
./dist/internal 4.1 kB
./dist/package.json 6.3 kB
./dist/plugins 4.1 kB
./dist/plugins/acorn.d.ts 109 B
./dist/plugins/acorn.js 152 kB
./dist/plugins/acorn.mjs 152 kB
./dist/plugins/angular.d.ts 177 B
./dist/plugins/angular.js 85.8 kB
./dist/plugins/angular.mjs 85.1 kB
./dist/plugins/babel.d.ts 419 B
./dist/plugins/babel.js 314 kB
./dist/plugins/babel.mjs 314 kB
./dist/plugins/estree.d.ts 11 B
./dist/plugins/estree.js 201 kB
./dist/plugins/estree.mjs 201 kB
./dist/plugins/flow.d.ts 90 B
./dist/plugins/flow.js 680 kB
./dist/plugins/flow.mjs 679 kB
./dist/plugins/glimmer.d.ts 93 B
./dist/plugins/glimmer.js 138 kB
./dist/plugins/glimmer.mjs 137 kB
./dist/plugins/graphql.d.ts 93 B
./dist/plugins/graphql.js 43.8 kB
./dist/plugins/graphql.mjs 43.1 kB
./dist/plugins/html.d.ts 139 B
./dist/plugins/html.js 152 kB
./dist/plugins/html.mjs 151 kB
./dist/plugins/markdown.d.ts 127 B
./dist/plugins/markdown.js 149 kB
./dist/plugins/markdown.mjs 148 kB
./dist/plugins/meriyah.d.ts 93 B
./dist/plugins/meriyah.js 131 kB
./dist/plugins/meriyah.mjs 131 kB
./dist/plugins/postcss.d.ts 121 B
./dist/plugins/postcss.js 153 kB
./dist/plugins/postcss.mjs 153 kB
./dist/plugins/typescript.d.ts 96 B
./dist/plugins/typescript.js 889 kB
./dist/plugins/typescript.mjs 888 kB
./dist/plugins/yaml.d.ts 90 B
./dist/plugins/yaml.js 122 kB
./dist/plugins/yaml.mjs 122 kB
./dist/README.md 4.03 kB
./dist/standalone.d.ts 1.37 kB
./dist/standalone.js 82.1 kB
./dist/standalone.mjs 81.9 kB

compressed-size-action

@fisker fisker mentioned this pull request Oct 8, 2024
Merged
4 tasks
@renovate renovate bot force-pushed the renovate/file-entry-cache-10.x branch 2 times, most recently from 0202fa2 to 92ae1d4 Compare October 9, 2024 06:34
@renovate renovate bot force-pushed the renovate/file-entry-cache-10.x branch from af3cd5e to f9fbe3f Compare January 8, 2025 13:10
@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 8, 2025 •
edited
Loading

Open in Stackblitz

npm i https://pkg.pr.new/prettier@16725

commit: 913a4ef

@fisker fisker force-pushed the renovate/file-entry-cache-10.x branch from d84d1ef to 3c1ce31 Compare January 8, 2025 14:45
fisker
fisker reviewed Jan 8, 2025
View reviewed changes
tests/integration/__tests__/cache.js
});

it("doesn't re-format when timestamp has been updated", async () => {
it("re-format when timestamp has been updated", async () => {
Copy link
Member

@fisker fisker Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sosukesuzuki file-entry-cache v10 consider file changed if mtime changed even useChecksum: true.

https://github.com/jaredwray/cacheable/blob/e2e035296810b704b9a6e06a2628bdfa7ed1bfa0/packages/file-entry-cache/src/index.ts#L265
https://github.com/jaredwray/cacheable/blob/e2e035296810b704b9a6e06a2628bdfa7ed1bfa0/packages/file-entry-cache/src/index.ts#L299

in v9 when useChecksum: true it doesn't count mtime change, see _getMetaForFileUsingCheckSum and _getMetaForFileUsingMtimeAndSize in https://unpkg.com/browse/[email protected]/cache.js

I think it's fine to change the behavior.

Copy link

@phillipuniverse phillipuniverse May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI this broke caching in CI workflows. See #17278

@renovate renovate bot force-pushed the renovate/file-entry-cache-10.x branch from 7e6747e to 2ce4145 Compare January 11, 2025 16:39
@fisker
Copy link
Member

fisker commented Jan 12, 2025

Damn it, why renovate force pushed for no reason? My changes are lot. I'll find them back when I back to my laptop.

@fisker
Copy link
Member

fisker commented Jan 12, 2025 •
edited
Loading

Log shows it's request, but no detailed information https://developer.mend.io/github/prettier/prettier/-/job/01945622-c8eb-744d-a74b-323f929132ff

@fisker fisker force-pushed the renovate/file-entry-cache-10.x branch from 2ce4145 to 7e6747e Compare January 13, 2025 05:20
@renovate
Copy link
Contributor Author

renovate bot commented Jan 13, 2025

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@fisker fisker force-pushed the renovate/file-entry-cache-10.x branch from 7e6747e to 3c9a086 Compare January 13, 2025 05:30
@fisker fisker requested a review from sosukesuzuki January 16, 2025 22:55
@fisker fisker added this to the 3.5 milestone Jan 16, 2025
sosukesuzuki
sosukesuzuki approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@sosukesuzuki sosukesuzuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this. In the future, we may can use @file-cache to implement cache.

@fisker fisker merged commit 36460be into main Jan 17, 2025
33 checks passed
@fisker fisker deleted the renovate/file-entry-cache-10.x branch January 17, 2025 15:48
@fisker fisker mentioned this pull request Mar 24, 2025
Closed
@fisker fisker mentioned this pull request May 7, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fisker fisker fisker left review comments

@sosukesuzuki sosukesuzuki sosukesuzuki approved these changes

+1 more reviewer

@phillipuniverse phillipuniverse phillipuniverse left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dependency Dependency Upgrade

Projects

None yet

Milestone

3.5

Development

Successfully merging this pull request may close these issues.

4 participants

@fisker @phillipuniverse @sosukesuzuki