-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Fix adjacent markdown syntax in blockquote #16596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix adjacent markdown syntax in blockquote #16596
Conversation
commit: |
Thank you 🙏 |
Please add changelog for this. |
Sure, thanks 🙏 |
Thanks already for this. I wanted to that this issue will start happening more often since the [GFM note extension] is gaining popularity and easily triggers this.
Which renders to: Note Prettier will break this. Will be formatted to:
And render to:
|
That's a different issue #15479 You can fix in another PR, if you want. |
I mean this PR fixes this already. I just forgot to mention this. |
No, it's not. Nottice Prettier pr-16596 --parser markdown
--prose-wrap always Input: > [!NOTE]
> [Prettier](https://prettier.io) will break this. Output: > [!NOTE] [Prettier](https://prettier.io) will break this.
|
I see, that's right. I used |
✅ Deploy Preview for prettier ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Description
Picking up work on #9099 with a slightly other approach than #9125. It's still hacky but the best way would require way more refactoring.
I'm checking whether the restored node value matches a newline followed by
>
(with optional spaces if it does just return the original node.Checklist
docs/
directory).changelog_unreleased/*/XXXX.md
file followingchangelog_unreleased/TEMPLATE.md
.✨Try the playground for this PR✨