Fix handling of new keyword and call signatures and improve type parameter formatting #1491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azz
added
type:bug
azz
changed the title
azz
changed the title
azz
changed the title
azz
added
the
type:enhancement
despairblue
reviewed
May 3, 2017
| @@ -0,0 +1,13 @@ | |||
| interface Interface { | |||
| < | |||
| Voila, | |||
| function printTypeParameters(path, options, print, paramsKey) { | ||
| const n = path.getValue(); | ||
|
|
||
| // In flow, Foo<> is acceptable. In TypeScript, it's a syntax error. |
There was a problem hiding this comment.
If it's a syntax error, shouldn't we never get here in the first place?
vjeux
reviewed
May 3, 2017
| @@ -1,3 +1,4 @@ | |||
| node_modules | |||
| npm-debug.log | |||
| /test.js | |||
| /.vscode | |||
There was a problem hiding this comment.
If you could configure your editor to add trailing empty lines that would be great!
vjeux
reviewed
May 3, 2017
| @@ -3,6 +3,6 @@ | |||
| exports[`cunstructorType.ts 1`] = ` | |||
| var d: new(x: number) => void; | |||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | |||
| var d: new(x: number) => void; | |||
| var d: new (x: number) => void; | |||
There was a problem hiding this comment.
is the whitespace here intended?
There was a problem hiding this comment.
Yes. new is a keyword, so the space helps distinguish it from a method.
There was a problem hiding this comment.
Okay, I just wanted to make sure that it wasn't a mistake.
lock
bot
added
the
locked-due-to-inactivity
fisker
removed
the
type:bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
interface<T> {}new <T>(): anyandnew <T> => any<T>() => anyand<T>(): any