Fix order of override modifiers #10961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
thorn0
approved these changes
May 28, 2021
Shinigami92
approved these changes
May 28, 2021
fisker
approved these changes
May 29, 2021
alexander-akait
approved these changes
May 29, 2021
lukaw3d
reviewed
Jun 7, 2021
|
|
||
| // Prettier stable | ||
| class Foo extends Bar { | ||
| override abstract foo: string; |
There was a problem hiding this comment.
CHANGELOG.md#fix-order-of-override-modifiers-10961-by-sosukesuzuki has this flipped, and it makes no sense anymore.
Blame: a34b4a7
sosukesuzuki
added a commit
to sosukesuzuki/prettier
that referenced
this pull request
Sep 16, 2021
thorn0
pushed a commit
that referenced
this pull request
Sep 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#10642 (comment)
Checklist
changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨