Rewrite skipEffects tests

preactjs · Apr 19, 2020 · e9ad038 · e9ad038
1 parent 61279d7
commit e9ad038
Showing 1 changed file with 19 additions and 12 deletions.
diff --git a/hooks/test/browser/hooks.options.test.js b/hooks/test/browser/hooks.options.test.js
@@ -127,21 +127,28 @@ describe('hook options', () => {
 		]);
 	});
 
-	it('should skip effect hooks', () => {
-		options._skipEffects = true;
-		const spy = sinon.spy();
-		function App() {
-			useEffect(spy, []);
-			useLayoutEffect(spy, []);
-			return null;
-		}
+	describe('Effects', () => {
+		beforeEach(() => {
+			options._skipEffects = options.__s = true;
+		});
 
-		act(() => {
-			render(<App />, scratch);
+		afterEach(() => {
+			options._skipEffects = options.__s = false;
 		});
 
-		expect(spy.callCount).to.equal(0);
+		it('should skip effect hooks', () => {
+			const spy = sinon.spy();
+			function App() {
+				useEffect(spy, []);
+				useLayoutEffect(spy, []);
+				return null;
+			}
 
-		options._skipEffects = false;
+			act(() => {
+				render(<App />, scratch);
+			});
+
+			expect(spy.callCount).to.equal(0);
+		});
 	});
 });