Skip to content

Conversation

@rubiin
Copy link
Contributor

@rubiin rubiin commented Sep 17, 2024

Pull Request

Description

Please read these instructions and remove unnecessary text.

  • Try to include a summary of the changes and which issue is fixed.
  • Also include relevant motivation and context (if applicable).
  • List any dependencies that are required for this change. (e.g., packages or other PRs)
  • Provide a link if there is an issue related to this pull request. e.g., Fixes # (issue)
  • Please add Reviewers, Assignees, Labels, Projects, and Milestones to the PR. (if applicable)

Type of change

Please put an x in the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (non-breaking change; modified files are limited to the documentations)
  • Technical debt (a code change that does not fix a bug or add a feature but makes something clearer for devs)
  • Other (provide details below)

Checklist

Please put an x in the boxes that apply:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My commit message follows the commit guidelines.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added a changelog entry.
  • I have added necessary comments/documentation to my code.
  • I have added tests to cover my changes.
  • I have tested my code locally and it works as expected.
  • All new and existing tests passed.

Screenshots

(if appropriate)

Additional context

Add any other context about the problem here.

@rubiin rubiin mentioned this pull request Sep 17, 2024
16 tasks
Copy link
Contributor

@abenezerw abenezerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look nice

@rubiin
Copy link
Contributor Author

rubiin commented Sep 17, 2024

And just 1.2mb overall 💯

@rubiin
Copy link
Contributor Author

rubiin commented Sep 17, 2024

might delete this one https://github.com/prasanthrangan/hyprdots/blob/main/Configs/.config/fastfetch/pngs/aisaka.png and add 3 more images each 200kb

@abenezerw
Copy link
Contributor

might delete this one https://github.com/prasanthrangan/hyprdots/blob/main/Configs/.config/fastfetch/pngs/aisaka.png and add 3 more images each 200kb

Maybe don’t delete the existing Hyde pngs in fast fetch.

@rubiin
Copy link
Contributor Author

rubiin commented Sep 17, 2024

Done and done 🤙

Copy link
Contributor

@abenezerw abenezerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are amazing

@rubiin
Copy link
Contributor Author

rubiin commented Nov 14, 2024

LGTM

@kRHYME7
Copy link
Collaborator

kRHYME7 commented Nov 15, 2024

Planning to put these "icons" into themes. What do you think about it?

Something like *.icon in the theme directory.

Fast fetch will try to find the theme icons first then if it doesn't exist fallback to the pngs in fastfetch??

@rubiin rubiin closed this by deleting the head repository Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants