Tokunbo #91
Open
Tokunbo #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Teea-dev is attempting to deploy a commit to the pqoqubbw Team on Vercel. A member of the Team first needs to authorize it. |
|
hey, for lock icon it's okay just show open state. also there are a few fixes for lock icon: you should move not only body of the lock to the bottom |
|
regarding hearts:
|
pqoqubbw
reviewed
Jan 3, 2025
icons/heart-crack.tsx
Outdated
Comment on lines
33
to
34
| width="24" | ||
| height="24" |
There was a problem hiding this comment.
Suggested change
| width="24" | |
| height="24" | |
| width="28" | |
| height="28" |
There was a problem hiding this comment.
Making changes to these now
pqoqubbw
reviewed
Jan 3, 2025
icons/heart-crack.tsx
Outdated
| className="cursor-pointer select-none p-2 hover:bg-accent rounded-md transition-colors duration-200 flex items-center justify-center" | ||
| onMouseEnter={() => controls.start('animate')} | ||
| onMouseLeave={() => controls.start('normal')} | ||
| style={{ display: 'inline-block' }} |
There was a problem hiding this comment.
you mean the style right?
pqoqubbw
reviewed
Jan 3, 2025
icons/heart.tsx
Outdated
| className="cursor-pointer select-none p-2 hover:bg-accent rounded-md transition-colors duration-200 flex items-center justify-center" | ||
| onMouseEnter={() => controls.start('animate')} | ||
| onMouseLeave={() => controls.start('normal')} | ||
| style={{ display: 'inline-block' }} |
pqoqubbw
reviewed
Jan 3, 2025
icons/heart.tsx
Outdated
Comment on lines
32
to
33
| width="24" | ||
| height="24" |
pqoqubbw
reviewed
Jan 3, 2025
icons/lock.tsx
Outdated
Comment on lines
51
to
52
| width="24" | ||
| height="24" |
pqoqubbw
requested changes
Jan 3, 2025
my bad |
…vg size and also moved not only the body of the lock to the bottom, changed the heart-crack animation (not soo sure I got it tho) and other changes as requested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have read the CONTRIBUTING.md file.
YES
I have run
yarn gen-clito generate the necessary filesYES
What kind of change does this PR introduce?
added three new icons and also fixed the clipboard-check icon
What is the new behavior?
addition of three new icons and a fix to one
Feel free to include screenshots if it includes visual changes.
Demo
Please attach a short video demo of the changes.
lock.icon.mp4
heart.icons.mp4
Additional context
Add any other context or screenshots.