Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SFCGAL] bump hash and use new gitlab url #364

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

lbartoletti
Copy link
Contributor

Hash: Bump to latest version
Url: SFCGAL have now a dedicated group on gitlab

@phillipross
Copy link
Contributor

@lbartoletti thanks for the contribution!
@ImreSamu This PR looks fine to me but can you give it look and make sure it's good to merge?

@ImreSamu
Copy link
Member

ImreSamu commented Nov 1, 2023

@phillipross :
looks OK.

Non-critical comment:
It appears that the two master Dockerfiles have been manually modified, as only the SFCGAL hash has been updated and the rest have not.
If you can add an update generated by running ./update.sh (as an extra commit),
then we can be certain there won't be any issues with future updates.

@phillipross
Copy link
Contributor

@ImreSamu good point, thanks!

@lbartoletti Did you understand the request? Please run the ./update.sh script in your branch and commit the results to make sure everything else is updated. Thanks!

@ImreSamu ImreSamu self-requested a review November 7, 2023 03:03
@ImreSamu
Copy link
Member

ImreSamu commented Nov 7, 2023

@phillipross :
I have run the ./update.sh command and committed the updates.
I believe everything is fine. It's ready for merging!
(Only the CircleCI test is not working right now; but I will try to fix that later, it's not causing any problems at the moment.)

@lbartoletti: Thank you for the pull request!

@phillipross phillipross merged commit ab6f209 into postgis:master Nov 7, 2023
28 of 29 checks passed
@lbartoletti
Copy link
Contributor Author

lbartoletti commented Nov 9, 2023

Sorry, I was sick last week and so, no reactive :).
Thanks for the hints and the update!

@lbartoletti lbartoletti deleted the update_sfcgal branch November 9, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants